Refactor of schema metrics #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetuk
force-pushed
the
unified-schema-metric
branch
from
3bb5b55 to
2197ef1
Compare
Batch21
approved these changes
Apr 15, 2024
| Self::TablesArray(p) => ParameterType::Parameter(p.add_to_model(network, args)?), | ||
| Self::Constant(p) => pywr_core::parameters::ParameterType::Parameter(p.add_to_model(network, args)?), | ||
| Self::ControlCurveInterpolated(p) => { | ||
| pywr_core::parameters::ParameterType::Parameter(p.add_to_model(network, args)?) |
There was a problem hiding this comment.
Is switch to the full import paths in this function just for clarity?
jetuk
force-pushed
the
unified-schema-metric
branch
from
731058c to
8344049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the schema
OutputMetricandDynamicFloatValueto a single schemaMetricenum. This simplifies some of the loading and removes the heavily nested enum.It also implements an
OutputMetricin core that is used to hold additional information regarding the origin of a metric in the schema. This is useful for ensuring output data aligns with the schema model definition rather than the internal details of core.Outstanding items:
DynamicIndexValue