Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Capture conversion errors when using convert CLI. #143

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jetuk
Copy link
Member

@jetuk jetuk commented Mar 12, 2024

Alter the framework for the convert command to capture all the conversion errors and log them to the user.

Alter the framework for the convert command to capture all the
conversion errors and log them to the user.
@jetuk jetuk requested a review from Batch21 March 12, 2024 21:17
Copy link
Contributor

@Batch21 Batch21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on a couple of models and it works nicely.

@jetuk jetuk merged commit a0324a4 into main Mar 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants