Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SIMD imports to work with latest nightly. #141

Merged
merged 16 commits into from
Jan 11, 2025
Merged

Conversation

jetuk
Copy link
Member

@jetuk jetuk commented Mar 12, 2024

Add nightly builds to CI.

@jetuk jetuk requested a review from Batch21 March 12, 2024 15:01
@jetuk
Copy link
Member Author

jetuk commented Dec 16, 2024

The errors here are fixed in pyo3 v0.23. We won't be able to upgrade that until a Polars release is done.

@jetuk jetuk force-pushed the fix-nightly-builds branch from b0b4cf7 to 4a7c310 Compare December 16, 2024 15:53
@jetuk
Copy link
Member Author

jetuk commented Jan 11, 2025

@Batch21 this is now ready for merge if you have any time for review. Not a high priority though.

Copy link
Contributor

@Batch21 Batch21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it another read through and it all looks ok. There are some changes in there that seem to be unrelated to the SIMD stuff but I think that must be due to merging main into the branch a few times?

@jetuk jetuk merged commit 4dc8af0 into main Jan 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants