refactor: Make ParameterIndex generic #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `IndexParameterIndex` (awful name!) and `MultiValueParameterIndex` in favour of a generic `ParameterIndex<T>.` Where `T` is the return type of the associated `Parameter<T>`. This ensures there is stronger type constraints to prevent using the wrong index in the wrong vec of parameters.
jetuk
force-pushed
the
generic-parameter-index
branch
from
7187104 to
65125f3
Compare
Batch21
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
IndexParameterIndex(awful name!) andMultiValueParameterIndexin favour of a genericParameterIndex<T>.WhereTis the return type of the associatedParameter<T>. This ensures there is stronger type constraints to prevent using the wrong index in the wrong vec of parameters.