feat: Implement Parameter<usize> for PyParameter. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batch21
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Worked for me when loading the custom index parameter in the more complex model we were looking at the other day.
One thing I did notice is that when building the docs the PythonReturnType enum is not included so its not obvious how to set return type. Might be I'm not building them correctly.
|
I've added those types to the public API. They now appear in the docs. |
This supports using PyParameter as an index parameter with updated schema to define the return type of the Python method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports using PyParameter as an index parameter with updated schema to define the return type of the Python method.