Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pywr-schema-macro crate #136

Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat: add pywr-schema-macro crate #136

merged 1 commit into from
Mar 11, 2024

Conversation

Batch21
Copy link
Contributor

@Batch21 Batch21 commented Mar 11, 2024

This contains a derive macro that implements parameters and parameters_mut methods for nodes.

This contains a derive macro that implements `parameters` and `parameters_mut` methods for nodes.
@Batch21
Copy link
Contributor Author

Batch21 commented Mar 11, 2024

@jetuk I was able to copy over your code from the v1 schema with little modification. I've left in a TODO for parsing more complex node attribute types, such as factors and links.

@Batch21 Batch21 requested a review from jetuk March 11, 2024 09:52
@jetuk
Copy link
Member

jetuk commented Mar 11, 2024

This looks good enough to unblock #99 .

It will need some more refinement to handle the other fields types, but that can be part of a wider improvement.

@jetuk jetuk merged commit a865900 into main Mar 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants