chore: Remove completed TODOs. (#222)

pywr-core/src/metric.rs

@@ -76,15 +76,13 @@ impl MetricF64 {
             MetricF64::NodeVolume(idx) => Ok(state.get_network_state().get_node_volume(idx)?),
             MetricF64::AggregatedNodeInFlow(idx) => {
                 let node = model.get_aggregated_node(idx)?;
-                // TODO this could be more efficient with an iterator method? I.e. avoid the `Vec<_>` allocation
                 node.get_nodes()
                     .iter()
                     .map(|idx| state.get_network_state().get_node_in_flow(idx))
                     .sum::<Result<_, _>>()
             }
             MetricF64::AggregatedNodeOutFlow(idx) => {
                 let node = model.get_aggregated_node(idx)?;
-                // TODO this could be more efficient with an iterator method? I.e. avoid the `Vec<_>` allocation
                 node.get_nodes()
                     .iter()
                     .map(|idx| state.get_network_state().get_node_out_flow(idx))

pywr-core/src/node.rs

@@ -575,7 +575,7 @@ impl FlowConstraints {
     /// Defaults to f64::MAX if no parameter is defined.
     pub fn get_max_flow(&self, network: &Network, state: &State) -> Result<f64, PywrError> {
         match &self.max_flow {
-            None => Ok(f64::MAX), // TODO should this return infinity?
+            None => Ok(f64::MAX),
             Some(m) => m.get_value(network, state),
         }
     }

pywr-core/src/parameters/aggregated_index.rs

@@ -65,8 +65,6 @@ impl GeneralParameter<usize> for AggregatedIndexParameter {
         state: &State,
         _internal_state: &mut Option<Box<dyn ParameterState>>,
     ) -> Result<usize, PywrError> {
-        // TODO scenarios!
-
         let value: usize = match self.agg_func {
             AggIndexFunc::Sum => {
                 let mut total = 0;

pywr-core/src/parameters/constant.rs

@@ -57,7 +57,6 @@ impl Parameter for ConstantParameter {
     }
 }
 
-// TODO this should only need to implement `ConstantParameter` when that is implemented.
 impl ConstParameter<f64> for ConstantParameter {
     fn compute(
         &self,

pywr-core/src/parameters/division.rs

@@ -36,7 +36,6 @@ impl GeneralParameter<f64> for DivisionParameter {
         state: &State,
         _internal_state: &mut Option<Box<dyn ParameterState>>,
     ) -> Result<f64, PywrError> {
-        // TODO handle scenarios
         let denominator = self.denominator.get_value(model, state)?;
 
         if denominator == 0.0 {