Do not close the dialog if the form validation fails

pywr-editor · Feb 19, 2024 · 104e23d · 104e23d
1 parent efe8d8a
commit 104e23d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pywr_editor/dialogs/metadata/metadata_dialog.py b/pywr_editor/dialogs/metadata/metadata_dialog.py
@@ -65,5 +65,5 @@ def on_form_save(self) -> None:
         Save the form and close the dialog.
         :return: None
         """
-        self.form.on_save()
-        self.close()
+        if self.form.on_save():
+            self.close()
diff --git a/pywr_editor/dialogs/node/node_dialog.py b/pywr_editor/dialogs/node/node_dialog.py
@@ -75,8 +75,8 @@ def on_form_save(self) -> None:
         Save the form and close the dialog.
         :return: None
         """
-        self.form.save()
-        self.close()
+        if self.form.save():
+            self.close()
 
 
 class NodeDialogTitle(QWidget):