Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngr: Add as dedicated install extra, pip install pueblo[ngr] #145

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 18, 2025

What the title says.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.49%. Comparing base (774bc77) to head (72be215).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   85.12%   86.49%   +1.36%     
==========================================
  Files          26       26              
  Lines        1022     1022              
==========================================
+ Hits          870      884      +14     
+ Misses        152      138      -14     
Flag Coverage Δ
main 62.91% <ø> (ø)
ngr 51.27% <ø> (ø)
sfa-full 40.11% <ø> (?)
sfa-minimal 38.35% <ø> (ø)
snippet 29.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review January 18, 2025 18:49
@amotl amotl marked this pull request as draft January 18, 2025 18:50
@amotl amotl force-pushed the sfa branch 2 times, most recently from 0cb373d to 09e0d89 Compare January 18, 2025 19:14
Base automatically changed from sfa to main January 19, 2025 02:44
@amotl amotl marked this pull request as ready for review January 19, 2025 03:14
@amotl amotl merged commit 8f59b4a into main Jan 19, 2025
12 checks passed
@amotl amotl deleted the ngr-extra branch January 19, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant