Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFA: Subsystem for loading single-file applications #112

Merged
merged 7 commits into from
Jan 19, 2025
Merged

SFA: Subsystem for loading single-file applications #112

merged 7 commits into from
Jan 19, 2025

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 2, 2024

About

A generic Python loader, with capabilities for installing dependencies and seeding applications from remote resources.

References

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 81.27341% with 50 lines in your changes missing coverage. Please review.

Project coverage is 86.49%. Comparing base (0030e8c) to head (ef301c7).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pueblo/sfa/core.py 85.13% 22 Missing ⚠️
pueblo/util/program.py 75.00% 12 Missing ⚠️
pueblo/ngr/cli.py 71.42% 6 Missing ⚠️
pueblo/sfa/cli.py 80.00% 5 Missing ⚠️
pueblo/sfa/pep723.py 79.16% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   87.61%   86.49%   -1.12%     
==========================================
  Files          22       26       +4     
  Lines         783     1022     +239     
==========================================
+ Hits          686      884     +198     
- Misses         97      138      +41     
Flag Coverage Δ
main 62.91% <37.82%> (-8.74%) ⬇️
ngr 51.27% <37.45%> (-9.91%) ⬇️
sfa-full 40.11% <76.77%> (?)
sfa-minimal 38.35% <71.53%> (?)
snippet 29.54% <27.34%> (-3.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl force-pushed the sfa branch 5 times, most recently from b956646 to 0762760 Compare November 7, 2024 22:48
@amotl amotl force-pushed the sfa branch 2 times, most recently from a89c726 to 214dbd4 Compare November 9, 2024 23:43
@amotl amotl force-pushed the sfa branch 2 times, most recently from 07c4d26 to 08aee03 Compare January 18, 2025 17:47
@amotl amotl force-pushed the sfa branch 2 times, most recently from 05be5e6 to b1b3af7 Compare January 18, 2025 18:11
@amotl amotl marked this pull request as ready for review January 19, 2025 02:44
@amotl amotl merged commit 774bc77 into main Jan 19, 2025
12 checks passed
@amotl amotl deleted the sfa branch January 19, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant