Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2024_06_09_pyconcz23_wrapup_summary.md #89

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

baradrb
Copy link
Contributor

@baradrb baradrb commented Jun 8, 2024

First version

@hroncok
Copy link
Member

hroncok commented Jun 8, 2024

The images seem missing.

@baradrb
Copy link
Contributor Author

baradrb commented Jun 8, 2024

The images seem missing.

I uploaded them to /images/... 🤷 Can you help?

@hroncok
Copy link
Member

hroncok commented Jun 8, 2024

Not right now, perhaps tomorrow.

@hroncok
Copy link
Member

hroncok commented Jun 8, 2024

Oh, the images are already in the master branch.

@frenzymadness
Copy link
Member

The images uploaded to the master branch are *.jpg but the links in the text point to *.png so the images do not work even if I merge this PR to the master first.

@frenzymadness
Copy link
Member

The text looks good to me 👍

From .png to .jpg.
@baradrb
Copy link
Contributor Author

baradrb commented Jun 11, 2024

Thanks! I didn't notice the wrong image format. I fixed it now. So please if it's good now let's merge it to the stars :)

@frenzymadness
Copy link
Member

Last two errors:

  • /images/pyconcz23_juniors.jpg is missing. I guess it should point to pyconcz23_postits.jpg
  • {static}/images/pyconcz23_pyramid.jpg should be {static}/images/pyconcz23_pyramid.JPG

I'm gonna push a fixup commit to fix them both. It can be squashed during the merge.

@frenzymadness
Copy link
Member

Hmm, I don't have rights to push here directly so here is the necessary change:

diff --git a/content/2024_06_09_pyconcz23_wrapup_summary.md b/content/2024_06_09_pyconcz23_wrapup_summary.md
index e5b9d63..f8f8ed7 100644
--- a/content/2024_06_09_pyconcz23_wrapup_summary.md
+++ b/content/2024_06_09_pyconcz23_wrapup_summary.md
@@ -66,7 +66,7 @@ Half (51.7%) attendees came from Prague, 31.3% came from the rest of the Czech R
 For most attendees (72.4%), this was their first PyCon CZ ever, while 10.6% have been to 3 or more Czech PyCons (remember that this was the 6th edition).
 Regarding attendees' self-perceived level of skill in Python programming, 15.9% called themselves expert Pythonistas, 43.9% stated they have done some advanced stuff in Python, 29.4% have done a few things here and there, and 10.8% were beginners in Python.
 
-![pieces of advice]({static}/images/pyconcz23_juniors.jpg)
+![pieces of advice]({static}/images/pyconcz23_postits.jpg)
 
 _Junior Guru post-its, photo by Honza Javorek_
 
@@ -212,7 +212,7 @@ _The final speech and giving thanks to the organisers and volunteers was an emot
 # 2024?
 What's next? Who knows! We have not formed a new organiser team, specifically, there is no main organiser ready to take on the challenge yet (as of June 2024). Should you wish to join our team, feel free to drop us a line at [email protected]. And before we begin to prepare the next PyCon CZ, consider exploring and contributing to other community initiatives like PyLadies, Pyvo, PyData, and more!
 
-![human pyramid]({static}/images/pyconcz23_pyramid.jpg)
+![human pyramid]({static}/images/pyconcz23_pyramid.JPG)
 
 _Building a human pyramid is a tradition, photo by Honza Javorek_
 

@honzajavorek
Copy link
Member

Is this ready for re-review?

@clytaemnestra
Copy link
Member

Bulletpoints weren't rendered properly, so I fixed them. LGTM.

@clytaemnestra
Copy link
Member

Waiting for @baradrb to confirm if this can already be merged or should we wait for more reviews.

@clytaemnestra clytaemnestra merged commit 8207371 into master Aug 6, 2024
2 checks passed
@clytaemnestra clytaemnestra deleted the baradrb-patch-1 branch August 6, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants