fix(debug): fix --debug flag and associated tests #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dylanpulver
commented
Jul 4, 2024
dylanpulver
commented
- Fix --debug flag functionality
- Add tests using runner.invoke
- Fix and modify fetch_database function
- Ensure all tests pass with appropriate patchings
Closed
Closed
jeff-at-safety
requested changes
Jul 4, 2024
jeff-at-safety
approved these changes
Jul 4, 2024
dylanpulver
force-pushed
the
fix/debug-flag
branch
3 times, most recently
from
7bebee7
to
0df74b1
Compare
jeff-at-safety
approved these changes
Jul 9, 2024
tests/test_cli.py
Outdated
| pass | ||
|
|
||
| dummy_function() # Call the decorated function |
There was a problem hiding this comment.
i think lines 545 and 565 should be deleted, because it's not actually necessary to call the function in order to trigger the behavior. in fact, it's important that the behavior gets triggered before the function is called.
There was a problem hiding this comment.
Sounds good, fixed now!
dylanpulver
force-pushed
the
fix/debug-flag
branch
from
88c36f9
to
a76bc42
Compare
author Dylan Pulver <[email protected]> 1719603852 -0400 committer Dylan Pulver <[email protected]> 1720552637 -0400
dylanpulver
force-pushed
the
fix/debug-flag
branch
from
a76bc42
to
e3c5abc
Compare
|
This PR got messed up in rebasing, moved to #552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.