Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log file in tmp_path instead of 'somefile' #193

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 28, 2024

Simple fix for the logging tests which were writing a somefile on the filesystem. Now we use tmp_path fixture instead and check that the new log file exists when it should.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@pnuu pnuu self-assigned this Feb 28, 2024
@pnuu pnuu requested a review from mraspaud as a code owner February 28, 2024 06:55
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (7c50b7b) to head (10c99e2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   91.08%   91.15%   +0.07%     
==========================================
  Files          26       26              
  Lines        5370     5426      +56     
==========================================
+ Hits         4891     4946      +55     
- Misses        479      480       +1     
Flag Coverage Δ
unittests 91.15% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit cd3a263 into pytroll:main Feb 28, 2024
6 checks passed
@pnuu pnuu deleted the fix-logging-output-file branch February 28, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants