Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS product and level1c collector #62

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Apr 25, 2024

Add a PPS l1c collector that adds PPS lvl1c files to messages with PPS products

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest nwcsafpps_runner
  • Passes flake8 nwcsafpps_runner
  • Fully documented

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 40 lines in your changes missing coverage. Please review.

Project coverage is 75.67%. Comparing base (5354d27) to head (cf804bd).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
nwcsafpps_runner/pps_collector_lib.py 0.00% 28 Missing ⚠️
nwcsafpps_runner/message_utils.py 79.48% 4 Missing and 4 partials ⚠️
nwcsafpps_runner/pps_posttroll_hook.py 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   74.24%   75.67%   +1.43%     
==========================================
  Files          15       16       +1     
  Lines        1778     1879     +101     
  Branches      266      160     -106     
==========================================
+ Hits         1320     1422     +102     
+ Misses        419      415       -4     
- Partials       39       42       +3     
Flag Coverage Δ
unittests 75.67% <67.74%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ninahakansson ninahakansson marked this pull request as ready for review May 16, 2024 12:02
Nina.Hakansson and others added 8 commits May 29, 2024 08:47
Not sure how usefull the test is as most things (posttroll) are mocked.
Also I needed to set LOOP to false to avoid getting stuck in the loop in
_run_subscribe_publisher. Mening it is not tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant