Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash fake publisher when not started #58

Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 5, 2023

Fake publisher needs to crash when not started to mimic the behaviour of the real publishers

@mraspaud mraspaud added the bug label Dec 5, 2023
@mraspaud mraspaud requested a review from adybbroe December 5, 2023 10:18
@mraspaud mraspaud self-assigned this Dec 5, 2023
@mraspaud mraspaud marked this pull request as draft December 5, 2023 10:20
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (53398c7) 79.31% compared to head (46779ab) 79.60%.
Report is 2 commits behind head on main.

Files Patch % Lines
posttroll/testing.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   79.31%   79.60%   +0.28%     
==========================================
  Files          17       17              
  Lines        2166     2182      +16     
==========================================
+ Hits         1718     1737      +19     
+ Misses        448      445       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud mraspaud marked this pull request as ready for review December 5, 2023 10:38
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 93833a2 into pytroll:main Dec 5, 2023
5 of 7 checks passed
@mraspaud mraspaud deleted the feature-patched-receiver-interuptible branch December 5, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants