Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testing's patched_subscriber_recv interruptible #57

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Make testing's patched_subscriber_recv interruptible #57

merged 1 commit into from
Dec 4, 2023

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 4, 2023

This makes it possible to catch cases when the subscriber is closed before all expected messages have arrived.

@mraspaud
Make patched_subscriber_recv interruptible
3e33ecf 
This makes it possible to catch cases when the subscriber is closed
before all expected messages have arrived.
@mraspaud mraspaud added the bug label Dec 4, 2023
@mraspaud mraspaud requested a review from pnuu December 4, 2023 15:02
@mraspaud mraspaud self-assigned this Dec 4, 2023
@mraspaud mraspaud mentioned this pull request Dec 4, 2023
Merged
adybbroe
adybbroe approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

posttroll/testing.py Show resolved Hide resolved
@mraspaud mraspaud merged commit 488aa17 into pytroll:main Dec 4, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe approved these changes

@pnuu pnuu Awaiting requested review from pnuu

Assignees

@mraspaud mraspaud

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraspaud @adybbroe