Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to address font failures when pkgconfig not installed #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eteq
Copy link

@eteq eteq commented May 28, 2021

This PR does two things that might be considered partial fixes for #74 :

  1. Adds a print statement that lets the user know pkgconfig wasn't found and installing it might help
  2. Adds a test that tries to open a font file.

Neither fully address the underlying problem in #74 that the pip install doesn't work, but this should at least make it easier to troubleshoot in the future.

@eteq eteq requested a review from mraspaud as a code owner May 28, 2021 20:28
@eteq
Copy link
Author

eteq commented May 28, 2021

I think the test failure is symptomatic of the underlying problem that leads to #74! 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant