Improve handling of multiple credentials #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzutu
suggested changes
Nov 24, 2024
| @@ -19,14 +19,13 @@ def get_settings(tr): | |||
| return formatted_json | |||
|
|
|||
|
|
|||
| def login(phone_no=None, pin=None, web=True): | |||
| def login(phone_no=None, pin=None, web=True, store_credentials=True): | |||
There was a problem hiding this comment.
Suggested change
| def login(phone_no=None, pin=None, web=True, store_credentials=True): | |
| def login(phone_no=None, pin=None, web=True, store_credentials=False): |
| "--store_credentials", | ||
| help="Store credentials (Phone number and pin) for next usage", | ||
| action="store_true", | ||
| default=True |
There was a problem hiding this comment.
I wouldn't save the credentials in a clear file per default when this behavior is not explicitly highlighted to the user.
Suggested change
| default=True |
| log.info("Credentials not saved") | ||
|
|
||
| tr = TradeRepublicApi(phone_no=phone_no, pin=pin, save_cookies=save_cookies) | ||
| tr = TradeRepublicApi(phone_no=phone_no, pin=pin, save_cookies=True) |
There was a problem hiding this comment.
Same critique here, the default behavior should not be to leave clear file cookies on your system indefinitely.
Suggested change
| tr = TradeRepublicApi(phone_no=phone_no, pin=pin, save_cookies=True) | |
| else: | |
| save_cookies = False | |
| log.info("Credentials not saved") | |
| tr = TradeRepublicApi(phone_no=phone_no, pin=pin, save_cookies=save_cookies) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm taking another attempt to fix #38 (Session is not invalidated when a new login with different number occurs) which hits me as well. There has already be an effort in #56 but it seems that this went stale.
My idea is to store the cookies in a file that is named after the phone number which is the id of a trade republic account. So there can be no conflicts in cookies if the tool is used with multiple accounts.
I also remove the prompt that asks whether one would like to save the credentials and replace it with a command line option
--store_credentialswhich defaults to true. I find the prompt rather annoying, especially for scripted calls of pytr.Comments/Suggestions?
Cheers
Christoph