Refactor VideoDecoder C++ initialization #435
Merged
+29
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the C++ layer, in
VideoDeocder::initializeDecoder()
, we were callingstd::vector::resize()
, adding 1 each time, and then callingstd::vector::back()
to get a reference to the last element and fill it out. That is not how vectors are designed to be used. Instead, in the loop, we just create a struct on the stack, fill it with values, and callstd::vector::push_back()
.