Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark refactoring. A bunch of minor option-name changes to make them shorter. Bigger change is removing
batch_parameters
as an option from the core runner. The problem is that we apply it to all other benchmark scenarios - except the data loading benchmark scenario, since that is in fact a kind of batch scenario. This is confusing and not easy to extend.We should figure out a way to generalize how to specify and run more scenarios, but I think a principle we should apply is that scenarios are self-contained. We don't want to have a scenario that implicitly applies itself to other scenarios.
For reference, the call:
Yields the results: