Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for runner-et #91

Merged
merged 10 commits into from
Apr 9, 2024
Merged

CI for runner-et #91

merged 10 commits into from
Apr 9, 2024

Conversation

metascroy
Copy link
Contributor

Attempt CI for runner-et with new ./scripts/install_et.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 8, 2024
@metascroy metascroy closed this Apr 9, 2024
@metascroy metascroy reopened this Apr 9, 2024
@metascroy metascroy requested review from mikekgfb and guangy10 April 9, 2024 17:41
Comment on lines +62 to +63
./build/cmake-out/runner_et ${PWD}/stories15M.pte -z ${MODEL_DIR}/tokenizer.bin -i "${PROMPT}" > ${PWD}/output_et
cat ${PWD}/output_et
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it different from

python generate.py --checkpoint-path ${MODEL_PATH} --temperature 0 --pte-path ${PWD}/${MODEL_NAME}.pte  > ${PWD}/output_et
          cat ${PWD}/output_et

Instead of adding a new worklfow for mac, can you add the et-runner changes to et.yml? You can extend the job to run both on linux and mac. I hope we can soon moving all the setup steps to some scripts and setup the same model tests we have in ExecuTorch so developers can really focus on enabling models w/ what configs (xnnpack, quant, aoti, etc.) in llama-fast but no worry about to run the model across all the platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that python generate.py calls ET using pybindings, and ./build/cmake-out/runner_et directly uses the ET C++ APIs (see https://github.com/pytorch-labs/llama-fast/tree/main/runner-et). There is currently no CI testing the runner-et, and I'd like it to not break.

I'd love to have these unified, but I cannot get them to run on the same runner. I cannot install the executorch python library on macos-14-xlarge because of this issue (https://fb.workplace.com/groups/osssupport/permalink/26054350164186919/), and I cannot get runner-et to build on linux. So this script installs executorch without pybindings (so that it works on macos-14-xlarge), and then builds (runner-et).

@metascroy metascroy merged commit 16a5ecf into main Apr 9, 2024
5 of 7 checks passed
@malfet malfet deleted the runner-et-ci branch April 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants