Removed global set_default_validate_args

[mctigger]

Description

Removed global set_default_validate_args

Motivation and Context

Having it true deviates from the default PyTorch behavior and may result in errors not raised.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

• Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[facebook-github-bot]

Hi @mctigger!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[vmoens]

Thanks for this.

In principle I support this change!
The reason we had this was that within ProbabilisticTensorDictModule, setting this to False can speed up the construction of the dists.

What would you think of raising a warning if this is True in ProbabilisticTensorDictModule.__init__ to let users know that they could do things faster? Maybe it's an overkill, not sure. Another option would be to put a .. note:: in ProbabilisticTensorDictModule docstrings to let users know that setting this to False can speed up the construction of the dists at the expense of safety.

If you could add one of those I'd be happy to merge this!