[BugFix] Reference cycle in TensorDict._cast_reduction

[egaznep]

Description

Resolve the reference cycle introduced by the function proc_dim.

Motivation and Context

close #1055

• I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds core functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (update in the documentation)
• Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[vmoens]

LGTM
Just need to fix the lint, and maybe add comments (or a test?) to avoid breaking this in the future

[egaznep]

Thanks for the feedback, will attend tomorrow the latest

…

On Wed, Oct 23, 2024, 22:37 Vincent Moens ***@***.***> wrote: ***@***.**** approved this pull request. LGTM Just need to fix the lint, and maybe add comments (or a test?) to avoid breaking this in the future — Reply to this email directly, view it on GitHub <#1056 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECMKFLNTLKZAO7IAAHC423Z5ACH5AVCNFSM6AAAAABQPGRRSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJQGQ4TSMJSGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[egaznep]

LGTM Just need to fix the lint, and maybe add comments (or a test?) to avoid breaking this in the future

Honestly I don't know how to test for reference cycles efficiently. I would be willing to implement if somebody provides directions.