Skip to content

[BugFix] Fix buffer identity in Params._apply (#1027) #1905

[BugFix] Fix buffer identity in Params._apply (#1027)

[BugFix] Fix buffer identity in Params._apply (#1027) #1905

Triggered via push October 4, 2024 12:41
Status Failure
Total duration 10m 1s
Artifacts

benchmarks.yml

on: push
CPU Pytest benchmark
8m 21s
CPU Pytest benchmark
GPU Pytest benchmark
9m 48s
GPU Pytest benchmark
Fit to window
Zoom out
Zoom in

Annotations

1 error and 3 warnings
CPU Pytest benchmark
# :warning: **Performance Alert** :warning: Possible performance regression was detected for benchmark **'CPU Benchmark Results'**. Benchmark result of this commit is worse than the previous benchmark result exceeding threshold `2`. | Benchmark suite | Current: 04faf408c143ff68b6acaf6568cdc3b8384da481 | Previous: 362c072dd9fbbd816eb9df19a6f79f0a7594b710 | Ratio | |-|-|-|-| | `benchmarks/common/memmap_benchmarks_test.py::test_serialize_weights_pickle` | `1.0830982240105338` iter/sec (`stddev: 0.3216190654579892`) | `2.410165998428883` iter/sec (`stddev: 0.06851554010875378`) | `2.23` | This comment was automatically generated by [workflow](https://github.com/pytorch/tensordict/actions?query=workflow%3AContinuous%20Benchmark) using [github-action-benchmark](https://github.com/marketplace/actions/continuous-benchmark). CC: @vmoens Comment was generated at https://github.com/pytorch/tensordict/commit/04faf408c143ff68b6acaf6568cdc3b8384da481#commitcomment-147575640
CPU Pytest benchmark
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
CPU Pytest benchmark
Performance alert! Previous value was 2.410165998428883 and current value is 1.0830982240105338. It is 2.2252515469044316x worse than previous exceeding a ratio threshold 2
GPU Pytest benchmark
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.