Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make benchmarked losses compatible with torch.compile #2405

Merged
merged 13 commits into from
Sep 17, 2024

Conversation

[ghstack-poisoned]
vmoens added a commit that referenced this pull request Aug 30, 2024
ghstack-source-id: 699a6bb6e4cb8982d09bf9aae447659e55e7f45e
Pull Request resolved: #2405
Copy link

pytorch-bot bot commented Aug 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2405

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Cancelled Job, 10 Unrelated Failures

As of commit e4441a0 with merge base 605b4aa (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2024
[ghstack-poisoned]
@vmoens vmoens added the enhancement New feature or request label Sep 2, 2024
[ghstack-poisoned]
[ghstack-poisoned]
@vmoens
Copy link
Contributor Author

vmoens commented Sep 3, 2024

Required merges before landing this:
pytorch/pytorch#135000 (comment)
pytorch/pytorch#135001

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vmoens vmoens merged commit e4441a0 into gh/vmoens/20/base Sep 17, 2024
54 of 70 checks passed
vmoens added a commit that referenced this pull request Sep 17, 2024
ghstack-source-id: 825ded593dcffcecf626a705d8b7c0c5e0839719
Pull Request resolved: #2405
@vmoens vmoens deleted the gh/vmoens/20/head branch September 17, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants