Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Higher time threshold for PEnv #1799

Merged
merged 1 commit into from
Jan 14, 2024
Merged

[BugFix] Higher time threshold for PEnv #1799

merged 1 commit into from
Jan 14, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 14, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1799

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 21 Unrelated Failures

As of commit c678d4e with merge base 95d8a1d (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2024
@vmoens vmoens added the bug Something isn't working label Jan 14, 2024
@vmoens vmoens merged commit 66d5a00 into main Jan 14, 2024
28 of 49 checks passed
@vmoens vmoens deleted the higher-penv-time-thr branch January 14, 2024 06:12
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 64.5103ms 64.3026ms 15.5515 Ops/s 15.1897 Ops/s $\color{#35bf28}+2.38\%$
test_sync 36.6884ms 34.1542ms 29.2790 Ops/s 28.3982 Ops/s $\color{#35bf28}+3.10\%$
test_async 82.1435ms 35.1417ms 28.4562 Ops/s 28.9567 Ops/s $\color{#d91a1a}-1.73\%$
test_simple 0.4991s 0.4439s 2.2525 Ops/s 2.1885 Ops/s $\color{#35bf28}+2.93\%$
test_transformed 0.6683s 0.6121s 1.6337 Ops/s 1.6088 Ops/s $\color{#35bf28}+1.55\%$
test_serial 1.4312s 1.3766s 0.7264 Ops/s 0.7026 Ops/s $\color{#35bf28}+3.39\%$
test_parallel 1.3773s 1.3466s 0.7426 Ops/s 0.7249 Ops/s $\color{#35bf28}+2.44\%$
test_step_mdp_speed[True-True-True-True-True] 54.3410μs 21.4057μs 46.7166 KOps/s 46.2986 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-True-True-True-False] 40.0140μs 13.1031μs 76.3180 KOps/s 75.3381 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[True-True-True-False-True] 44.6130μs 12.7997μs 78.1269 KOps/s 79.2038 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[True-True-True-False-False] 50.3450μs 7.6882μs 130.0702 KOps/s 126.0830 KOps/s $\color{#35bf28}+3.16\%$
test_step_mdp_speed[True-True-False-True-True] 53.0590μs 22.8074μs 43.8453 KOps/s 43.0495 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[True-True-False-True-False] 45.9260μs 14.6222μs 68.3890 KOps/s 67.9801 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-True-False-False-True] 57.9280μs 13.9560μs 71.6537 KOps/s 70.5038 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[True-True-False-False-False] 27.5910μs 8.9246μs 112.0501 KOps/s 108.7966 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[True-False-True-True-True] 62.5450μs 24.1648μs 41.3825 KOps/s 41.0129 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-False-True-True-False] 56.2250μs 15.8978μs 62.9019 KOps/s 63.1827 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[True-False-True-False-True] 56.3350μs 14.0360μs 71.2453 KOps/s 70.3773 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-False-True-False-False] 30.0870μs 8.9153μs 112.1670 KOps/s 109.7399 KOps/s $\color{#35bf28}+2.21\%$
test_step_mdp_speed[True-False-False-True-True] 64.3500μs 25.4044μs 39.3633 KOps/s 38.1923 KOps/s $\color{#35bf28}+3.07\%$
test_step_mdp_speed[True-False-False-True-False] 56.6660μs 17.1311μs 58.3735 KOps/s 57.3640 KOps/s $\color{#35bf28}+1.76\%$
test_step_mdp_speed[True-False-False-False-True] 55.5350μs 15.0257μs 66.5528 KOps/s 65.2652 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[True-False-False-False-False] 43.8000μs 10.1258μs 98.7576 KOps/s 96.9284 KOps/s $\color{#35bf28}+1.89\%$
test_step_mdp_speed[False-True-True-True-True] 55.7430μs 24.4119μs 40.9636 KOps/s 40.7541 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[False-True-True-True-False] 62.5960μs 15.6147μs 64.0423 KOps/s 63.2923 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[False-True-True-False-True] 47.9190μs 16.2983μs 61.3561 KOps/s 62.2104 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-True-True-False-False] 34.5940μs 10.1140μs 98.8733 KOps/s 99.0036 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-True-False-True-True] 70.9520μs 25.4056μs 39.3615 KOps/s 40.3102 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-False-True-False] 48.1490μs 16.9715μs 58.9224 KOps/s 58.0971 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[False-True-False-False-True] 56.9960μs 17.3856μs 57.5189 KOps/s 57.7614 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-False-False-False] 32.2400μs 11.4063μs 87.6710 KOps/s 87.4077 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[False-False-True-True-True] 54.9920μs 27.0040μs 37.0316 KOps/s 38.0697 KOps/s $\color{#d91a1a}-2.73\%$
test_step_mdp_speed[False-False-True-True-False] 59.5100μs 18.2856μs 54.6879 KOps/s 54.4761 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-False-True-False-True] 58.4590μs 17.3123μs 57.7625 KOps/s 57.7560 KOps/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[False-False-True-False-False] 48.8910μs 11.4047μs 87.6829 KOps/s 87.1978 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[False-False-False-True-True] 57.7280μs 27.6933μs 36.1098 KOps/s 35.9696 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-False-False-True-False] 66.0630μs 19.5081μs 51.2607 KOps/s 51.7930 KOps/s $\color{#d91a1a}-1.03\%$
test_step_mdp_speed[False-False-False-False-True] 64.0490μs 18.4226μs 54.2810 KOps/s 53.7112 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[False-False-False-False-False] 41.4170μs 12.5599μs 79.6184 KOps/s 80.5303 KOps/s $\color{#d91a1a}-1.13\%$
test_values[generalized_advantage_estimate-True-True] 13.5966ms 12.3054ms 81.2651 Ops/s 81.5893 Ops/s $\color{#d91a1a}-0.40\%$
test_values[vec_generalized_advantage_estimate-True-True] 33.1555ms 26.2303ms 38.1239 Ops/s 35.9767 Ops/s $\textbf{\color{#35bf28}+5.97\%}$
test_values[td0_return_estimate-False-False] 0.2310ms 0.1840ms 5.4357 KOps/s 5.4923 KOps/s $\color{#d91a1a}-1.03\%$
test_values[td1_return_estimate-False-False] 26.4521ms 26.0450ms 38.3951 Ops/s 38.5589 Ops/s $\color{#d91a1a}-0.42\%$
test_values[vec_td1_return_estimate-False-False] 36.1630ms 26.7621ms 37.3663 Ops/s 35.7913 Ops/s $\color{#35bf28}+4.40\%$
test_values[td_lambda_return_estimate-True-False] 39.9219ms 36.8684ms 27.1235 Ops/s 27.6583 Ops/s $\color{#d91a1a}-1.93\%$
test_values[vec_td_lambda_return_estimate-True-False] 33.8583ms 26.3750ms 37.9147 Ops/s 35.9467 Ops/s $\textbf{\color{#35bf28}+5.47\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.3521ms 8.2266ms 121.5564 Ops/s 120.0231 Ops/s $\color{#35bf28}+1.28\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.0204ms 1.8280ms 547.0372 Ops/s 529.7912 Ops/s $\color{#35bf28}+3.26\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 8.0824ms 0.4344ms 2.3022 KOps/s 2.3261 KOps/s $\color{#d91a1a}-1.03\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 40.3301ms 37.7332ms 26.5018 Ops/s 24.9755 Ops/s $\textbf{\color{#35bf28}+6.11\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.4910ms 2.6338ms 379.6735 Ops/s 378.7467 Ops/s $\color{#35bf28}+0.24\%$
test_dqn_speed 77.3514ms 8.1411ms 122.8335 Ops/s 128.0772 Ops/s $\color{#d91a1a}-4.09\%$
test_ddpg_speed 22.7824ms 14.7156ms 67.9552 Ops/s 67.5864 Ops/s $\color{#35bf28}+0.55\%$
test_sac_speed 33.5107ms 29.5042ms 33.8935 Ops/s 33.1918 Ops/s $\color{#35bf28}+2.11\%$
test_redq_speed 37.9822ms 35.9526ms 27.8144 Ops/s 28.0769 Ops/s $\color{#d91a1a}-0.94\%$
test_redq_deprec_speed 30.5338ms 25.7005ms 38.9098 Ops/s 38.7726 Ops/s $\color{#35bf28}+0.35\%$
test_td3_speed 28.6223ms 20.3420ms 49.1594 Ops/s 48.1501 Ops/s $\color{#35bf28}+2.10\%$
test_cql_speed 89.8049ms 88.0464ms 11.3576 Ops/s 11.2285 Ops/s $\color{#35bf28}+1.15\%$
test_a2c_speed 29.6543ms 27.2949ms 36.6369 Ops/s 36.1369 Ops/s $\color{#35bf28}+1.38\%$
test_ppo_speed 29.1138ms 27.6326ms 36.1892 Ops/s 35.7268 Ops/s $\color{#35bf28}+1.29\%$
test_reinforce_speed 27.3986ms 26.2682ms 38.0688 Ops/s 37.0945 Ops/s $\color{#35bf28}+2.63\%$
test_iql_speed 72.4880ms 64.5933ms 15.4815 Ops/s 15.3559 Ops/s $\color{#35bf28}+0.82\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 1.9883ms 1.4543ms 687.5992 Ops/s 694.3955 Ops/s $\color{#d91a1a}-0.98\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6288ms 0.5114ms 1.9556 KOps/s 1.9559 KOps/s $\color{#d91a1a}-0.02\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.9068ms 0.5061ms 1.9758 KOps/s 1.9898 KOps/s $\color{#d91a1a}-0.71\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 1.9183ms 1.4247ms 701.9111 Ops/s 709.6564 Ops/s $\color{#d91a1a}-1.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 8.7917ms 0.5116ms 1.9545 KOps/s 1.9325 KOps/s $\color{#35bf28}+1.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 96.1034ms 0.5770ms 1.7331 KOps/s 1.9962 KOps/s $\textbf{\color{#d91a1a}-13.18\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.4803ms 1.6390ms 610.1164 Ops/s 611.7074 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 97.4744ms 0.7352ms 1.3602 KOps/s 1.2509 KOps/s $\textbf{\color{#35bf28}+8.74\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.9534ms 0.6345ms 1.5761 KOps/s 1.5453 KOps/s $\color{#35bf28}+1.99\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.0793ms 1.4534ms 688.0552 Ops/s 695.2634 Ops/s $\color{#d91a1a}-1.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6267ms 0.5111ms 1.9566 KOps/s 1.9522 KOps/s $\color{#35bf28}+0.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 9.0715ms 0.5063ms 1.9751 KOps/s 1.9509 KOps/s $\color{#35bf28}+1.24\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.0331ms 1.4189ms 704.7469 Ops/s 710.2589 Ops/s $\color{#d91a1a}-0.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7065ms 0.5090ms 1.9648 KOps/s 1.9643 KOps/s $\color{#35bf28}+0.02\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 1.6130ms 0.4962ms 2.0155 KOps/s 2.0133 KOps/s $\color{#35bf28}+0.11\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 92.9259ms 1.8356ms 544.7850 Ops/s 552.5680 Ops/s $\color{#d91a1a}-1.41\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 8.8982ms 0.6539ms 1.5292 KOps/s 1.5185 KOps/s $\color{#35bf28}+0.70\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.9335ms 0.6396ms 1.5634 KOps/s 1.5423 KOps/s $\color{#35bf28}+1.37\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1334s 17.3708ms 57.5680 Ops/s 57.1030 Ops/s $\color{#35bf28}+0.81\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.8875ms 13.8516ms 72.1940 Ops/s 72.9752 Ops/s $\color{#d91a1a}-1.07\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.0746ms 3.2710ms 305.7216 Ops/s 300.3208 Ops/s $\color{#35bf28}+1.80\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1058s 16.9536ms 58.9844 Ops/s 59.0072 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.4601ms 13.7946ms 72.4920 Ops/s 73.5553 Ops/s $\color{#d91a1a}-1.45\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.4768ms 3.3011ms 302.9249 Ops/s 305.6498 Ops/s $\color{#d91a1a}-0.89\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1068s 17.1026ms 58.4706 Ops/s 58.4385 Ops/s $\color{#35bf28}+0.05\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.5631ms 13.9676ms 71.5942 Ops/s 71.7780 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.6360ms 3.5311ms 283.1988 Ops/s 282.7675 Ops/s $\color{#35bf28}+0.15\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1227s 0.1224s 8.1689 Ops/s 8.2370 Ops/s $\color{#d91a1a}-0.83\%$
test_sync 0.1774s 0.1095s 9.1313 Ops/s 9.0330 Ops/s $\color{#35bf28}+1.09\%$
test_async 0.2116s 0.1018s 9.8255 Ops/s 9.9146 Ops/s $\color{#d91a1a}-0.90\%$
test_single_pixels 0.1464s 0.1460s 6.8490 Ops/s 6.8393 Ops/s $\color{#35bf28}+0.14\%$
test_sync_pixels 97.7996ms 95.7262ms 10.4465 Ops/s 10.5018 Ops/s $\color{#d91a1a}-0.53\%$
test_async_pixels 0.2466s 92.4794ms 10.8132 Ops/s 10.8414 Ops/s $\color{#d91a1a}-0.26\%$
test_simple 0.9704s 0.8982s 1.1134 Ops/s 1.1275 Ops/s $\color{#d91a1a}-1.25\%$
test_transformed 1.2127s 1.1478s 0.8713 Ops/s 0.9007 Ops/s $\color{#d91a1a}-3.27\%$
test_serial 2.6267s 2.5619s 0.3903 Ops/s 0.4036 Ops/s $\color{#d91a1a}-3.29\%$
test_parallel 2.5530s 2.4863s 0.4022 Ops/s 0.3983 Ops/s $\color{#35bf28}+0.97\%$
test_step_mdp_speed[True-True-True-True-True] 0.1504ms 33.6316μs 29.7340 KOps/s 30.1773 KOps/s $\color{#d91a1a}-1.47\%$
test_step_mdp_speed[True-True-True-True-False] 41.8100μs 19.8169μs 50.4619 KOps/s 51.3121 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-True-True-False-True] 47.5810μs 19.2174μs 52.0363 KOps/s 52.4899 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-True-True-False-False] 49.1610μs 11.4709μs 87.1768 KOps/s 88.0404 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[True-True-False-True-True] 67.1310μs 35.8515μs 27.8928 KOps/s 28.4503 KOps/s $\color{#d91a1a}-1.96\%$
test_step_mdp_speed[True-True-False-True-False] 57.9200μs 21.8847μs 45.6940 KOps/s 47.0448 KOps/s $\color{#d91a1a}-2.87\%$
test_step_mdp_speed[True-True-False-False-True] 51.6710μs 21.1183μs 47.3522 KOps/s 47.9627 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[True-True-False-False-False] 43.3500μs 13.2955μs 75.2134 KOps/s 76.7633 KOps/s $\color{#d91a1a}-2.02\%$
test_step_mdp_speed[True-False-True-True-True] 57.8910μs 37.3974μs 26.7398 KOps/s 27.6717 KOps/s $\color{#d91a1a}-3.37\%$
test_step_mdp_speed[True-False-True-True-False] 71.3510μs 23.7369μs 42.1284 KOps/s 43.3381 KOps/s $\color{#d91a1a}-2.79\%$
test_step_mdp_speed[True-False-True-False-True] 50.5200μs 20.8633μs 47.9310 KOps/s 48.1518 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[True-False-True-False-False] 88.6410μs 13.4277μs 74.4732 KOps/s 75.5441 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[True-False-False-True-True] 59.0910μs 39.2284μs 25.4918 KOps/s 26.2604 KOps/s $\color{#d91a1a}-2.93\%$
test_step_mdp_speed[True-False-False-True-False] 43.2110μs 25.2075μs 39.6708 KOps/s 40.0062 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[True-False-False-False-True] 37.6810μs 22.6412μs 44.1673 KOps/s 44.9385 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[True-False-False-False-False] 49.2100μs 15.2503μs 65.5727 KOps/s 67.1790 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[False-True-True-True-True] 52.9510μs 38.0615μs 26.2732 KOps/s 27.5193 KOps/s $\color{#d91a1a}-4.53\%$
test_step_mdp_speed[False-True-True-True-False] 44.6010μs 23.5634μs 42.4387 KOps/s 42.7195 KOps/s $\color{#d91a1a}-0.66\%$
test_step_mdp_speed[False-True-True-False-True] 68.1210μs 25.5229μs 39.1805 KOps/s 41.1580 KOps/s $\color{#d91a1a}-4.80\%$
test_step_mdp_speed[False-True-True-False-False] 35.5800μs 15.5120μs 64.4663 KOps/s 67.5611 KOps/s $\color{#d91a1a}-4.58\%$
test_step_mdp_speed[False-True-False-True-True] 57.6210μs 39.2266μs 25.4929 KOps/s 25.8383 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[False-True-False-True-False] 57.5110μs 25.6046μs 39.0555 KOps/s 39.6587 KOps/s $\color{#d91a1a}-1.52\%$
test_step_mdp_speed[False-True-False-False-True] 49.1210μs 26.7318μs 37.4087 KOps/s 37.8731 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[False-True-False-False-False] 30.8900μs 16.9044μs 59.1562 KOps/s 59.6592 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[False-False-True-True-True] 58.5910μs 40.7999μs 24.5098 KOps/s 24.5782 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-False-True-True-False] 69.4110μs 27.6837μs 36.1224 KOps/s 36.8770 KOps/s $\color{#d91a1a}-2.05\%$
test_step_mdp_speed[False-False-True-False-True] 55.1710μs 27.0906μs 36.9132 KOps/s 38.0486 KOps/s $\color{#d91a1a}-2.98\%$
test_step_mdp_speed[False-False-True-False-False] 31.5710μs 17.0259μs 58.7339 KOps/s 60.6090 KOps/s $\color{#d91a1a}-3.09\%$
test_step_mdp_speed[False-False-False-True-True] 64.4310μs 42.8218μs 23.3526 KOps/s 24.2179 KOps/s $\color{#d91a1a}-3.57\%$
test_step_mdp_speed[False-False-False-True-False] 49.6610μs 29.3043μs 34.1247 KOps/s 34.9357 KOps/s $\color{#d91a1a}-2.32\%$
test_step_mdp_speed[False-False-False-False-True] 46.4310μs 28.8201μs 34.6980 KOps/s 35.5776 KOps/s $\color{#d91a1a}-2.47\%$
test_step_mdp_speed[False-False-False-False-False] 74.2810μs 18.7843μs 53.2359 KOps/s 54.9062 KOps/s $\color{#d91a1a}-3.04\%$
test_values[generalized_advantage_estimate-True-True] 24.8368ms 24.3097ms 41.1359 Ops/s 40.0200 Ops/s $\color{#35bf28}+2.79\%$
test_values[vec_generalized_advantage_estimate-True-True] 88.4111ms 3.3293ms 300.3656 Ops/s 307.4692 Ops/s $\color{#d91a1a}-2.31\%$
test_values[td0_return_estimate-False-False] 93.5810μs 60.9983μs 16.3939 KOps/s 15.4679 KOps/s $\textbf{\color{#35bf28}+5.99\%}$
test_values[td1_return_estimate-False-False] 52.1016ms 51.7461ms 19.3251 Ops/s 18.6574 Ops/s $\color{#35bf28}+3.58\%$
test_values[vec_td1_return_estimate-False-False] 2.0365ms 1.7560ms 569.4794 Ops/s 568.2269 Ops/s $\color{#35bf28}+0.22\%$
test_values[td_lambda_return_estimate-True-False] 84.4290ms 82.4193ms 12.1331 Ops/s 11.8387 Ops/s $\color{#35bf28}+2.49\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0810ms 1.7547ms 569.8951 Ops/s 568.6140 Ops/s $\color{#35bf28}+0.23\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.1781ms 22.9403ms 43.5915 Ops/s 42.0487 Ops/s $\color{#35bf28}+3.67\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8285ms 0.6882ms 1.4532 KOps/s 1.3884 KOps/s $\color{#35bf28}+4.67\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7328ms 0.6481ms 1.5430 KOps/s 1.5418 KOps/s $\color{#35bf28}+0.08\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5244ms 1.4506ms 689.3735 Ops/s 688.7625 Ops/s $\color{#35bf28}+0.09\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9241ms 0.6706ms 1.4912 KOps/s 1.4943 KOps/s $\color{#d91a1a}-0.21\%$
test_dqn_speed 14.2546ms 7.5663ms 132.1655 Ops/s 135.4539 Ops/s $\color{#d91a1a}-2.43\%$
test_ddpg_speed 15.5743ms 14.7892ms 67.6169 Ops/s 69.0111 Ops/s $\color{#d91a1a}-2.02\%$
test_sac_speed 30.5773ms 29.8001ms 33.5569 Ops/s 34.0061 Ops/s $\color{#d91a1a}-1.32\%$
test_redq_speed 37.3029ms 35.3586ms 28.2817 Ops/s 28.6670 Ops/s $\color{#d91a1a}-1.34\%$
test_redq_deprec_speed 25.1626ms 24.2086ms 41.3076 Ops/s 41.0600 Ops/s $\color{#35bf28}+0.60\%$
test_td3_speed 29.0319ms 20.1510ms 49.6253 Ops/s 50.1422 Ops/s $\color{#d91a1a}-1.03\%$
test_cql_speed 85.1142ms 84.5602ms 11.8259 Ops/s 11.8598 Ops/s $\color{#d91a1a}-0.29\%$
test_a2c_speed 28.3711ms 27.2182ms 36.7401 Ops/s 37.0985 Ops/s $\color{#d91a1a}-0.97\%$
test_ppo_speed 28.2735ms 27.5851ms 36.2515 Ops/s 36.6182 Ops/s $\color{#d91a1a}-1.00\%$
test_reinforce_speed 27.1135ms 26.3950ms 37.8860 Ops/s 38.3243 Ops/s $\color{#d91a1a}-1.14\%$
test_iql_speed 59.4025ms 58.0311ms 17.2321 Ops/s 17.2992 Ops/s $\color{#d91a1a}-0.39\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5731ms 1.8982ms 526.8211 Ops/s 520.6874 Ops/s $\color{#35bf28}+1.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9815ms 0.8388ms 1.1921 KOps/s 1.1907 KOps/s $\color{#35bf28}+0.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9378ms 0.8255ms 1.2114 KOps/s 1.2068 KOps/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.0823ms 1.8965ms 527.2863 Ops/s 526.4997 Ops/s $\color{#35bf28}+0.15\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0752ms 0.8292ms 1.2059 KOps/s 1.2066 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1124s 0.9529ms 1.0495 KOps/s 1.2222 KOps/s $\textbf{\color{#d91a1a}-14.13\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1203ms 2.1618ms 462.5877 Ops/s 459.8515 Ops/s $\color{#35bf28}+0.60\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0723ms 0.9588ms 1.0430 KOps/s 1.0419 KOps/s $\color{#35bf28}+0.11\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0661ms 0.9504ms 1.0522 KOps/s 1.0519 KOps/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6213ms 1.9121ms 522.9913 Ops/s 520.0941 Ops/s $\color{#35bf28}+0.56\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9344ms 0.8396ms 1.1911 KOps/s 1.1910 KOps/s $\color{#35bf28}+0.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9438ms 0.8269ms 1.2093 KOps/s 1.2062 KOps/s $\color{#35bf28}+0.26\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.5201ms 1.8828ms 531.1164 Ops/s 526.9924 Ops/s $\color{#35bf28}+0.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1124s 0.9804ms 1.0200 KOps/s 1.2049 KOps/s $\textbf{\color{#d91a1a}-15.35\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9411ms 0.8187ms 1.2214 KOps/s 1.2213 KOps/s $\color{#35bf28}+0.01\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2125ms 2.1709ms 460.6383 Ops/s 458.0859 Ops/s $\color{#35bf28}+0.56\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0919ms 0.9589ms 1.0429 KOps/s 1.0417 KOps/s $\color{#35bf28}+0.11\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0764ms 0.9511ms 1.0514 KOps/s 1.0530 KOps/s $\color{#d91a1a}-0.16\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1250s 18.2369ms 54.8338 Ops/s 53.8436 Ops/s $\color{#35bf28}+1.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.5575ms 14.1841ms 70.5015 Ops/s 61.0958 Ops/s $\textbf{\color{#35bf28}+15.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.0407ms 3.4026ms 293.8891 Ops/s 288.9486 Ops/s $\color{#35bf28}+1.71\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1209s 18.0777ms 55.3167 Ops/s 54.7638 Ops/s $\color{#35bf28}+1.01\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.3713ms 14.1767ms 70.5383 Ops/s 70.7351 Ops/s $\color{#d91a1a}-0.28\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.9155ms 3.4270ms 291.8037 Ops/s 288.8558 Ops/s $\color{#35bf28}+1.02\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1218s 18.3371ms 54.5344 Ops/s 54.0491 Ops/s $\color{#35bf28}+0.90\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.9438ms 14.4665ms 69.1251 Ops/s 69.5043 Ops/s $\color{#d91a1a}-0.55\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.0943ms 3.5386ms 282.5972 Ops/s 273.8297 Ops/s $\color{#35bf28}+3.20\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot