Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for torch.concat operator. #7161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Michiel-Olieslagers
Copy link

Added torch.ops.aten.concatenate.default in the list of supported operators in the generic annotator. This allows torch.concat operators to be lowered to aten.

Also added a test to check the functionality of the newly added operator to ensure functionality of added operator is preserved in future.

Added torch.ops.aten.concatenate.default in the list of supported operators in the generic annotator. Also added a test to check the functionality of the newly added operator.

Change-Id: I24d0fbf96bf9fd57ebd059cefd2af0f525fe8235
Copy link

pytorch-bot bot commented Dec 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7161

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c6584df with merge base 22a75be (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @Michiel-Olieslagers!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Dec 3, 2024
Copy link

pytorch-bot bot commented Dec 3, 2024

Please seek CI approval before scheduling CIFlow labels

@@ -53,6 +53,7 @@
torch.ops.aten.tile.default,
torch.ops.aten.flip.default,
torch.ops.aten.cat.default,
torch.ops.aten.concatenate.default,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really see this op after export?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants