-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for torch.concat operator. #7161
base: main
Are you sure you want to change the base?
Conversation
Added torch.ops.aten.concatenate.default in the list of supported operators in the generic annotator. Also added a test to check the functionality of the newly added operator. Change-Id: I24d0fbf96bf9fd57ebd059cefd2af0f525fe8235
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7161
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c6584df with merge base 22a75be (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Please seek CI approval before scheduling CIFlow labels |
@@ -53,6 +53,7 @@ | |||
torch.ops.aten.tile.default, | |||
torch.ops.aten.flip.default, | |||
torch.ops.aten.cat.default, | |||
torch.ops.aten.concatenate.default, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really see this op after export?
Added torch.ops.aten.concatenate.default in the list of supported operators in the generic annotator. This allows torch.concat operators to be lowered to aten.
Also added a test to check the functionality of the newly added operator to ensure functionality of added operator is preserved in future.