Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-VK] Removing unnecessary and redundant members from VulkanBuffer and ParamsBuffer. #7144

Open
wants to merge 2 commits into
base: gh/trivedivivek/16/base
Choose a base branch
from

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented Dec 2, 2024

…and ParamsBuffer.

This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer.

Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Dec 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7144

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 278bd83 with merge base 2d499b3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66557456

Copy link

github-actions bot commented Dec 2, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…lkanBuffer and ParamsBuffer."

This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer.

Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Dec 2, 2024
…and ParamsBuffer.

Pull Request resolved: #7144

This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer.
ghstack-source-id: 256100389
@exported-using-ghexport

Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66557456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: vulkan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants