Add scuba logging to edge API's #7103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7103
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 366493b with merge base a347665 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: #7103 Differential Revision: D66385141
facebook-github-bot
force-pushed
the
export-D66385141
branch
from
0a5ce34
to
3c97772
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
JacobSzwejbka
approved these changes
Nov 27, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Reviewed By: JacobSzwejbka Differential Revision: D66385141
facebook-github-bot
force-pushed
the
export-D66385141
branch
from
3c97772
to
b2a0ee4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Reviewed By: JacobSzwejbka Differential Revision: D66385141
facebook-github-bot
force-pushed
the
export-D66385141
branch
from
b2a0ee4
to
9b0dea2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Reviewed By: JacobSzwejbka Differential Revision: D66385141
facebook-github-bot
force-pushed
the
export-D66385141
branch
from
9b0dea2
to
afb6f36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
tarun292
added a commit
that referenced
this pull request
Dec 2, 2024
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Pull Request resolved: #7103 Reviewed By: JacobSzwejbka Differential Revision: D66385141
tarun292
force-pushed
the
export-D66385141
branch
from
afb6f36
to
b179e4b
Compare
tarun292
added a commit
that referenced
this pull request
Dec 2, 2024
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Pull Request resolved: #7103 Reviewed By: JacobSzwejbka Differential Revision: D66385141
tarun292
force-pushed
the
export-D66385141
branch
from
b179e4b
to
0230d5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
tarun292
added a commit
that referenced
this pull request
Dec 2, 2024
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Pull Request resolved: #7103 Reviewed By: JacobSzwejbka Differential Revision: D66385141
tarun292
force-pushed
the
export-D66385141
branch
from
0230d5f
to
5a051a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
Summary: Adding scuba logging to the Edge AOT API's. Whenever the API's are used this will log some basic details to Scuba and also if the API call fails it will log the stack trace and the reason why it failed, to Scuba. This is only enabled for internal users and for OSS users it'll essentially be a no-op. The cases where logging is done: - User uses the API in a notebook - User uses the API via `buck run` or `buck test` on devserver Logging will not be done if the API is called via automated tests. Reviewed By: JacobSzwejbka Differential Revision: D66385141
facebook-github-bot
force-pushed
the
export-D66385141
branch
from
5a051a9
to
366493b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66385141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66385141