Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executorch] Add quantized kv cache to oss ci #6997

Merged
merged 33 commits into from
Dec 5, 2024

Conversation

kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Nov 20, 2024

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6997

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 42ad61a with merge base cd306d3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
kimishpatel added a commit that referenced this pull request Nov 20, 2024
Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

ghstack-source-id: 254679000
Pull Request resolved: #6997
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Nov 21, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 254687228
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Nov 21, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 254774011
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

kimishpatel added a commit that referenced this pull request Nov 21, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 254871264
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

kimishpatel added a commit that referenced this pull request Nov 22, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 254902439
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

kimishpatel added a commit that referenced this pull request Nov 22, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 254987269
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Nov 22, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 255034795
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256616977
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256619056
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256626712
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256628952
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256637054
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256710069
@exported-using-ghexport

//unit-test-arm broken in trunk plus complains about internal failure
@bypass-github-export-checks
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256711932
@exported-using-ghexport

//unit-test-arm broken in trunk plus complains about internal failure
@bypass-github-export-checks
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
Fixes to make sure quantized kv cache works in oss

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Dec 5, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256718639
@exported-using-ghexport

//unit-test-arm broken in trunk plus complains about internal failure
@bypass-github-export-checks
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66269487

@facebook-github-bot facebook-github-bot merged commit d0404ee into gh/kimishpatel/145/base Dec 5, 2024
74 of 75 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/kimishpatel/145/head branch December 5, 2024 21:20
kimishpatel added a commit that referenced this pull request Dec 6, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256718639
@exported-using-ghexport

//unit-test-arm broken in trunk plus complains about internal failure
@bypass-github-export-checks
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)
kimishpatel added a commit that referenced this pull request Dec 7, 2024
Pull Request resolved: #6997

Fixes to make sure quantized kv cache works in oss
ghstack-source-id: 256718639
@exported-using-ghexport

//unit-test-arm broken in trunk plus complains about internal failure
@bypass-github-export-checks
@exported-using-ghexport

Differential Revision: [D66269487](https://our.internmc.facebook.com/intern/diff/D66269487/)

Co-authored-by: Kimish Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants