Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows x64 Build Support with xnnpack #6979

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

vortex-captain
Copy link

@vortex-captain vortex-captain commented Nov 20, 2024

Summary

This PR introduces support for out-of-the-box builds on Windows x64 with xnnpack, simplifying the setup process for developers using executorch on Windows. Additionally, it lays the groundwork for future Windows build pipelines and prebuilt PyPI packages.

Fixes #4661

Test plan

PR tested by running minimal executor_runner example (https://pytorch.org/executorch/stable/getting-started-setup.html#run-your-program) in the following environment:

  • Windows 11 x64
  • Visual Studio Enterprise 2022 with these components installed:
    • C++ Clang tools for Windows
    • MSBuild support for LLVM (clang-cl) toolset
    • C++ CMake tools for Windows

Steps:

# run the following in command prompt
cd executorch/  # contains code of this PR
git pull
git submodule sync
git submodule update --init

./install_requirements.bat --pybind xnnpack
Remove-Item -Path "add.pte" -ErrorAction SilentlyContinue
python .\export_add.py  # export_add.py from https://pytorch.org/executorch/stable/getting-started-setup.html#export-a-program
msbuild pip-out\temp.win-amd64-cpython-310\cmake-out\executorch.sln /t:Rebuild
pip-out\temp.win-amd64-cpython-310\cmake-out\Debug\executor_runner.exe --model-path add.pte

References

#4681

Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6979

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d46f329 with merge base 3475707 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
Copy link

pytorch-bot bot commented Nov 21, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'Release' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@vortex-captain
Copy link
Author

@pytorchbot label "Release notes: build"

Copy link

pytorch-bot bot commented Nov 21, 2024

Didn't find following labels among repository labels: Release notes: build

@vortex-captain
Copy link
Author

@pytorchbot label "release notes: build"

@pytorch-bot pytorch-bot bot added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Nov 21, 2024
@vortex-captain vortex-captain marked this pull request as ready for review November 21, 2024 03:24
@vortex-captain
Copy link
Author

Hi @kirklandsign and @dbort! Could you kindly help assign reviewers to this PR? Many thanks!

vortex-captain and others added 2 commits November 22, 2024 09:48
- attempt to fix extension/data_loader/file_data_loader.cpp:20:10: fatal error: 'executorch/runtime/platform/unistd.h' file not found
@vortex-captain
Copy link
Author

Hi @dbort I attempted to address the issues in the checks, could you kindly help rerun them? Thanks 😄

@vortex-captain vortex-captain changed the title Windows x64 Build Support Windows x64 Build Support with xnnpack Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support build on native Windows
3 participants