HiFi optimizations for mean, where, min, max, pow, rem and quantized_linear operators. #6867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding mean and where ops optimized on HiFi
* adding pow, remainder, minimum, maximum operators * adding pow, remainder, minimum, maximum operators
Adding quantized linear optimized versions for int8 and uint8
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6867
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit f1f0bb3 with merge base ce77995 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
zonglinpeng
approved these changes
Nov 21, 2024
| - op: maximum.out | ||
| kernels: | ||
| - arg_meta: null | ||
| kernel_name: impl::HiFi::maximum_out |
There was a problem hiding this comment.
Please change all kernel_names here to match cadence::impl::HiFi::native::OP_NAME. For example: cadence::impl::HiFi::native::add_out
| using torch::executor::resize_to_broadcast_target_size; | ||
|
|
||
| namespace impl { | ||
| namespace HiFi { |
There was a problem hiding this comment.
Can the name spaces of all the ops build as
namespace cadence {
namespace impl {
namespace HiFi {
namespace native {
To align with other ops? HiFi example: https://github.com/pytorch/executorch/blob/main/backends/cadence/hifi/operators/op_add.cpp#L25
mcremon-meta
approved these changes
Nov 27, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HiFi optimizations for mean, where, min, max, pow, rem and quantized_linear operators.
Test plan
Unit tested for individual operators using pte files. Also tested with babyllama, rnnt models available for Cadence target.