Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add a workflow dispatch for uploading release artifact #5606

Closed
wants to merge 24 commits into from
Closed

[Android] Add a workflow dispatch for uploading release artifact #5606

wants to merge 24 commits into from

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5606

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2549ec5 with merge base 8660faf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2024
@kirklandsign kirklandsign changed the title Android upload artifact 2 [Android] Add a workflow dispatch for uploading release artifact Sep 24, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign mentioned this pull request Sep 24, 2024
Closed
huydhn
huydhn approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 13869ec.

@kirklandsign kirklandsign deleted the android-upload-artifact-2 branch September 26, 2024 21:16
@kirklandsign
Copy link
Contributor Author

kirklandsign commented Sep 26, 2024 •
edited
Loading

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

Note: This is an infra only change and very useful for releasing artifacts for 0.4.

pytorchbot pushed a commit that referenced this pull request Sep 26, 2024
@kirklandsign @pytorchbot
Add a workflow dispatch for uploading release artifact (#5606)
be05b61 
Summary: Pull Request resolved: #5606

Reviewed By: huydhn

Differential Revision: D63346406

Pulled By: kirklandsign

fbshipit-source-id: 1682c0e7e4f5dea4419b18a158762a4630f2bdcb
(cherry picked from commit 13869ec)
@pytorchbot
Copy link
Collaborator

Cherry picking #5606

The cherry pick PR is at #5708 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 26, 2024
Closed
dvorjackz pushed a commit that referenced this pull request Sep 26, 2024
@pytorchbot @kirklandsign
[Android] Add a workflow dispatch for uploading release artifact (#5708)
25a1be8 
Add a workflow dispatch for uploading release artifact (#5606)

Summary: Pull Request resolved: #5606

Reviewed By: huydhn

Differential Revision: D63346406

Pulled By: kirklandsign

fbshipit-source-id: 1682c0e7e4f5dea4419b18a158762a4630f2bdcb
(cherry picked from commit 13869ec)

Co-authored-by: Hansong Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirklandsign @facebook-github-bot @pytorchbot @huydhn