-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove overridden prefill API declaration in llava_runner.h #5149
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5149
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b45df8a with merge base 96a9d35 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
* @param start_pos The starting position in KV cache of the input in the LLM. | ||
* It's passed as reference and will be updated inside this function. | ||
* @return The error status of prefilling images. | ||
*/ | ||
Error prefill_images(std::vector<Image>& images, int64_t& start_pos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete these apis since they are in the base class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably everything
executorch/examples/models/llava/runner/llava_runner.h
Lines 31 to 52 in f9764dc
bool is_loaded(); | |
Error load(); | |
Error generate( | |
std::vector<Image> images, | |
const std::string& prompt, | |
int32_t seq_len = 1024, | |
std::function<void(const std::string&)> token_callback = {}, | |
std::function<void(const ::executorch::extension::llm::Stats&)> | |
stats_callback = {}); | |
Error prefill_images(std::vector<Image>& images, int64_t& start_pos); | |
Result<uint64_t> prefill_prompt( | |
const std::string& prompt, | |
int64_t& start_pos, | |
int8_t bos = 0, | |
int8_t eos = 0); | |
Error generate_from_pos( | |
const std::string& prompt, | |
int32_t seq_len = 1024, | |
int64_t start_pos = 0, | |
std::function<void(const std::string&)> token_callback = {}, | |
std::function<void(const ::executorch::extension::llm::Stats&)> | |
stats_callback = {}); |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Already declared in extension/llm/runner/multimodal_runner.h
2024523
to
e07afdd
Compare
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Already in extension/llm/runner/multimodal_runner.h