Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XNNPACK pytest cleanup #3646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

XNNPACK pytest cleanup #3646

wants to merge 2 commits into from

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented May 16, 2024 •
edited
Loading

Summary

Enable a lot of XNNPACK pytest test cases!

  • Test file names should start with test_ to be collected by pytest
  • Add ops test to pytest.ini
  • Avoid Tester to be collected

Test plan

pytest

Differential Revision: D57463419

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3646

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 102524e with merge base 4b1323d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57463419

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57463419

kirklandsign added a commit to kirklandsign/executorch that referenced this pull request Jun 12, 2024
@kirklandsign @facebook-github-bot
XNNPACK pytest cleanup (pytorch#3646)
e6c6d8e 
Summary:
* Test file names should start with test_ to be collected by pytest
* Add ops test to pytest.ini
* Avoid Tester to be collected

Pull Request resolved: pytorch#3646

Reviewed By: swolchok

Differential Revision: D57463419

Pulled By: kirklandsign
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57463419

kirklandsign added a commit to kirklandsign/executorch that referenced this pull request Jun 13, 2024
@kirklandsign @facebook-github-bot
XNNPACK pytest cleanup (pytorch#3646)
ab6a764 
Summary:
* Test file names should start with test_ to be collected by pytest
* Add ops test to pytest.ini
* Avoid Tester to be collected

Pull Request resolved: pytorch#3646

Reviewed By: swolchok

Differential Revision: D57463419

Pulled By: kirklandsign
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57463419

kirklandsign added a commit to kirklandsign/executorch that referenced this pull request Jun 21, 2024
@kirklandsign @facebook-github-bot
XNNPACK pytest cleanup (pytorch#3646)
85237d4 
Summary:
* Test file names should start with test_ to be collected by pytest
* Add ops test to pytest.ini
* Avoid Tester to be collected

Pull Request resolved: pytorch#3646

Reviewed By: swolchok

Differential Revision: D57463419

Pulled By: kirklandsign
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcr229 mcr229 mcr229 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @facebook-github-bot @mcr229