Run only a subset for optim benchmarks, attempt to fix #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janeyx99
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
janeyx99
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
janeyx99
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
janeyx99
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
janeyx99
commented
Jul 23, 2024
| @@ -579,8 +592,6 @@ def run_model(modelName, device, Optim, defaults, maybe_pt2_): | |||
| len(params), | |||
| params[0].device, | |||
| ) | |||
| if Optim.__name__ == "SGD": | |||
| defaults["lr"] = 1e-2 | |||
There was a problem hiding this comment.
no longer necessary as we have a default LR for SGD now
janeyx99
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
janeyx99
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
janeyx99
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
janeyx99
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
janeyx99
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
janeyx99
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
janeyx99
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
janeyx99
commented
Jul 23, 2024
| @@ -412,7 +412,7 @@ def get_metrics_by_date( | |||
| if not start_date: | |||
| raise RuntimeError( | |||
| f"No start date in previous JSONS found to compare towards the end date {end_date}. User specified start date: {args.start_date}. " | |||
| + f"Available JSON dates: {available_metrics_jsons.keys()}. No regression info has been generated." | |||
There was a problem hiding this comment.
available_metrics_jsons doesn't have keys anymore as it's a List[str] and not a dict. It's unclear whether there were ever keys. Just remove the printout for now as it's not needed for the error message.
xuzhao9
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first attempt to fix https://github.com/pytorch/benchmark/actions/workflows/userbenchmark-regression-detector.yml by only running a subset of models
Impact of this change:
This workflow is green: https://github.com/pytorch/benchmark/actions/runs/10066723358/job/27828703722
It also takes so much shorter. At one point, the benchmark was 7 hours! Now it's 7 minutes.
Test Plan
Test run: https://github.com/pytorch/benchmark/actions/runs/10065401507
Final test run: https://github.com/pytorch/benchmark/actions/runs/10066723358/job/27828703722