-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bisection routine by creating GitHub issue only when the bisection is successful #2050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2023 23:58 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2023 23:58 — with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
November 20, 2023 23:59 — with
GitHub Actions
Inactive
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2023 23:59 — with
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
November 21, 2023 00:00 — with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
November 21, 2023 00:02 — with
GitHub Actions
Inactive
xuzhao9
force-pushed
the
xz9/improve-v3-bisect
branch
from
January 11, 2024 22:09
46f180d
to
ed85419
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
January 11, 2024 22:09 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
January 11, 2024 22:09 — with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
January 11, 2024 22:15 — with
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
January 11, 2024 22:15 — with
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
January 12, 2024 00:16 — with
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
January 12, 2024 00:16 — with
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
January 12, 2024 18:52 — with
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
January 12, 2024 18:52 — with
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
January 12, 2024 19:15 — with
GitHub Actions
Inactive
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aaronenyeshi
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve the noisy issues of the V3 nightly workflow.
When a regression is detected, we will first kick off a bisection workflow, and only create the GitHub issue when the bisection workflow fails or finds the root cause commit. If the bisection succeeds, but it does not find any result, we will not create an issue.
Test plan:
https://github.com/pytorch/benchmark/actions/runs/7506472200