Skip to content

Commit

Permalink
Catch more exception types when running eager in PT2 tests (#117120)
Browse files Browse the repository at this point in the history
Summary:
https://github.com/pytorch/pytorch/actions/runs/7467073391/job/20320251143#step:16:1332 shows a case where model loading fails with KeyError but the error is not logged in the report csv file, which can cause an eager model failure silently ignored in the PT2 integration test.

X-link: pytorch/pytorch#117120
Approved by: https://github.com/huydhn

Reviewed By: osalpekar

Differential Revision: D52718166

Pulled By: desertfire

fbshipit-source-id: cf11c6b92b53202bbe9048cfe156f4e75bc04390
  • Loading branch information
desertfire authored and facebook-github-bot committed Jan 12, 2024
1 parent 0062ea3 commit e24f12d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion userbenchmark/dynamo/dynamobench/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -3783,7 +3783,7 @@ def run(runner, args, original_dir=None):
batch_size=batch_size,
extra_args=extra_args,
)
except RuntimeError as e:
except Exception as e:
import traceback

mode = "train" if args.training else "eval"
Expand Down

0 comments on commit e24f12d

Please sign in to comment.