torchfix: Refactor ERROR_CODE to be consistent #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors ERROR_CODE --> ERROR, introduces a new TorchError class that defines what an error is including its code + the message it's supposed to have since I found that most errors were defined by the Code at the top + a string message that was semi-hard to find amongst the code. This also makes it so that ERRORS needs to be a list instead of being optionally a list or a value to make it more consistent. Signed-off-by: Eli Uriegas <[email protected]>
facebook-github-bot
added
the
CLA Signed
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
|
Thanks. |
kit1980
approved these changes
Apr 22, 2024
I think consistency here is the more important part because having an either or scenario can make it a bit confusing. |
kit1980
added a commit
that referenced
this pull request
Apr 24, 2024
kit1980
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors ERROR_CODE --> ERROR, introduces a new TorchError class that defines what an error is including its code + the message it's supposed to have since I found that most errors were defined by the Code at the top + a string message that was semi-hard to find amongst the code.
This also makes it so that ERRORS needs to be a list instead of being optionally a list or a value to make it more consistent.
Relates to #6 since I'll use this backing to auto-generate documentation for all of the error codes we support