Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for TorchVisionModelsImportVisitor #29

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix for TorchVisionModelsImportVisitor #29

merged 2 commits into from
Mar 12, 2024

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Mar 11, 2024

Add codemod tests, don't replace when an import statement has more than 1 name (but still print the message).

@kit1980 kit1980 requested a review from gesuwen March 11, 2024 22:49
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2024
@kit1980 kit1980 requested a review from huydhn March 11, 2024 22:49
huydhn
huydhn approved these changes Mar 12, 2024
View reviewed changes
Copy link

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kit1980 kit1980 merged commit 5e51d01 into main Mar 12, 2024
2 checks passed
@kit1980 kit1980 deleted the sdym/import-models branch March 19, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@gesuwen gesuwen Awaiting requested review from gesuwen

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kit1980 @huydhn @facebook-github-bot