Test against Python 3.13 #587
Conversation
There was a problem hiding this comment.
Tests pass on Python 3.13, but coverage fails due to not covering three lines
Wrote XML report to coverage.xml
Name Stmts Miss Cover Missing
-----------------------------------------------------------
toolz/__init__.py [14](https://github.com/pytoolz/toolz/actions/runs/11076807214/job/30780696578?pr=587#step:6:15) 0 100%
toolz/_signatures.py 143 3 98% 732, 746, 768
toolz/curried/__init__.py 49 0 100%
toolz/curried/exceptions.py 10 0 100%
toolz/curried/operator.py 8 0 100%
toolz/dicttoolz.py 105 0 100%
toolz/functoolz.py 412 0 100%
toolz/itertoolz.py 363 0 100%
toolz/recipes.py 9 0 100%
toolz/sandbox/__init__.py 2 0 100%
toolz/sandbox/core.py 37 0 100%
toolz/sandbox/parallel.py 19 0 100%
toolz/utils.py 7 0 100%
-----------------------------------------------------------
TOTAL 1[17](https://github.com/pytoolz/toolz/actions/runs/11076807214/job/30780696578?pr=587#step:6:18)8 3 99%
Coverage failure: total of 99 is less than fail-under=100
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1178 1178
=========================================
Hits 1178 1178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -42,9 +43,8 @@ jobs: | |||
| if: (! contains(matrix.python-version, 'pypy')) | |||
| run: | | |||
| coverage xml | |||
| coverage report --show-missing --fail-under=100 | |||
There was a problem hiding this comment.
Removing this line here as it requires every single CI build to have 100% coverage. This isn't quite right in cases when there are Python version-specific lines of code (which we have in toolz).
Instead, let's merge coverage reports across all CI build with codecov to make sure that, summed across all Python versions, we have 100% coverage.
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
We were having coverage report upload issues, so I had to bump the version of the codecov action being used here
In preparation for Python 3.13 coming out (looks like sometime next week https://peps.python.org/pep-0719/#schedule)
Closes #581