Makes the mprof executable use sys.executable instead of "python" for subprocess
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Whenever I try to do the 'mprof run <filename.py> ' it says 'mprof is not recognized as an internal or external command'. |
pquentin
reviewed
Oct 5, 2017
| cmd_line = get_cmd_line(args) | ||
| args[1:1] = ("-m", "memory_profiler", "--timestamp", | ||
| "-o", mprofile_output) | ||
| #print(" ".join(args)) |
|
Apart from the comment that @pquentin left, this will need a rebase. Anyone else wants to do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
mprof runstarts a subprocess, it now usessys.executableas the python interpreter instead of the string python.This is useful so the user can run mprof with a python version that is not in the first hit in the current PATH.