-
Notifications
You must be signed in to change notification settings - Fork 2
Update mono repo locations + Add python 3.6 support #5
base: master
Are you sure you want to change the base?
Conversation
@vmuriart @cowboygneox I noticed you weren't tagged on this, but have reviewed PRs in the past. Thought I would bump this PR since it would be useful for me too. |
Looks good to me, though I wish it would build. |
@vmuriart @chrisjbremner @zteisberg looks like travis allows this kind of builds only for repo owners, here is a similar issue: |
@zteisberg i added you as collaborator to test out the hypothesis about travis permissions |
@zteisberg can you send me your email for docker account to be added to pythonnet? my email is in my github profile. |
@zteisberg I'm confused as to why you're pointing at a mono snapshot and not updating the mono version? Looks fine otherwise. |
@cowboygneox I think the details from #6 answer the question.
|
@denfromufa This is probably the reason why our builds are failing. I remember seeing that on my feeds a while back, but didn't think much of it till just now. Though I've looked into it a bit more, and it seems we are following all the recommendations. I tried building directly (non-PR) and fails to authenticate as well. I wonder if we need to re-setup the secure ENV and then try again... Leaving these resources here to look into later: https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry |
The docker-build/authentication is a separate issue from what this PR is trying to do. Any objections to merge this in? Sounded like @cowboygneox was ok with the changes as well. |
@vmuriart who will push the actual built docker containers to docker hub? I'm getting authentication errors even on my local machine. |
@denfromufa good point. I'll give it a try when I get home |
The docker install on my machine is broken. Couldn't tests locally. |
@cowboygneox: I'm not @zteisberg, but I suspect he did this because if you don't pin to the specific version
@vmuriart: I ran this command using Docker for Mac version 17.09.1 (latest from the stable channel) and it built the image and exited without error:
|
For anyone else who finds this issue while searching for a Pythonnet Docker image with Python 3.6: To cover the time until the CI workflow in this repo is fixed, I have created a repo with a wider range of Python and Mono versions here, including Python 3.6: I'd be happy to contribute these back to this repo here if that's of interest to the maintainers, and/or would appreciate feedback and contributions over in https://github.com/jonemo/pythonnet-docker. |
@jonemo would you like to try and push this to main pythonnet docker repo? if yes, send me your email address. |
@jonemo I added you to both pythonnet-docker and github-pythonnet-docker collaborators. Feel free to push your updates directly there. |
I was added as a collaborator here. Is that a request for me to jump in? |
Sean,
I added the same permissions for 3 people on both dockerhub and
github-pythonnet-docker.
If you would like to take a look at the problem, that is encouraged :)
In 2-3 weeks @jonemo may jump in to sync his docker pythonnet channel with
this official channel.
…On Tue, Jun 12, 2018, 6:31 AM Sean Freitag ***@***.***> wrote:
I was added as a collaborator here. Is that a request for me to jump in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHgZ5RaKLhgTftYwvzHumfKXffEmUZ5Yks5t76Z8gaJpZM4Qd7sn>
.
|
Hello,
I also tried to run it exactly as it is in this PR, but it fails with the same error. |
@michaelosthege you can probably check in the mono gitter channel first about this weird error "Too many project files specified" |
Edit:
To give context about change of mono repo location