Skip to content
This repository has been archived by the owner on Jun 9, 2020. It is now read-only.

Update mono repo locations + Add python 3.6 support #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zteisberg
Copy link
Collaborator

@zteisberg zteisberg commented Nov 14, 2017

Edit:
To give context about change of mono repo location

I ran into an error building a docker image from the dockerfile. It indicated that '4.8.0.520-0xamarin3' for 'mono-complete' was not found. I changed it to point the Ubuntu snapshot for 4.8.0.520 and it worked. -- @fdanny #6

@chrisjbremner
Copy link

@vmuriart @cowboygneox I noticed you weren't tagged on this, but have reviewed PRs in the past. Thought I would bump this PR since it would be useful for me too.

@vmuriart
Copy link
Contributor

Looks good to me, though I wish it would build.
@denfromufa any idea why our build is failing with invalid credentials?

@den-run-ai
Copy link
Contributor

den-run-ai commented Dec 21, 2017

@vmuriart @chrisjbremner @zteisberg looks like travis allows this kind of builds only for repo owners, here is a similar issue:

appium/appium-docker-android#34

@den-run-ai
Copy link
Contributor

@zteisberg i added you as collaborator to test out the hypothesis about travis permissions

@den-run-ai
Copy link
Contributor

@zteisberg can you send me your email for docker account to be added to pythonnet? my email is in my github profile.

@cowboygneox
Copy link

cowboygneox commented Dec 26, 2017

@zteisberg I'm confused as to why you're pointing at a mono snapshot and not updating the mono version?

Looks fine otherwise.

@vmuriart
Copy link
Contributor

@cowboygneox I think the details from #6 answer the question.

I ran into an error building a docker image from the dockerfile. It indicated that '4.8.0.520-0xamarin3' for 'mono-complete' was not found. I changed it to point the Ubuntu snapshot for 4.8.0.520 and it worked.

@vmuriart
Copy link
Contributor

@denfromufa This is probably the reason why our builds are failing. I remember seeing that on my feeds a while back, but didn't think much of it till just now.

Though I've looked into it a bit more, and it seems we are following all the recommendations. I tried building directly (non-PR) and fails to authenticate as well.

I wonder if we need to re-setup the secure ENV and then try again...

Leaving these resources here to look into later:
https://medium.com/mobileforgood/coding-tips-patterns-for-continuous-integration-with-docker-on-travis-ci-9cedb8348a62

https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry

@vmuriart vmuriart requested review from vmuriart and removed request for vmuriart December 27, 2017 05:55
@vmuriart
Copy link
Contributor

The docker-build/authentication is a separate issue from what this PR is trying to do.
Just looking at the changes I'm ok with merging without waiting to resolve the Travis build.

Any objections to merge this in? Sounded like @cowboygneox was ok with the changes as well.

@den-run-ai
Copy link
Contributor

@vmuriart who will push the actual built docker containers to docker hub? I'm getting authentication errors even on my local machine.

@vmuriart
Copy link
Contributor

@denfromufa good point. I'll give it a try when I get home

@vmuriart
Copy link
Contributor

The docker install on my machine is broken. Couldn't tests locally.

@jonemo
Copy link
Collaborator

jonemo commented Jan 3, 2018

@zteisberg I'm confused as to why you're pointing at a mono snapshot and not updating the mono version?

@cowboygneox: I'm not @zteisberg, but I suspect he did this because if you don't pin to the specific version 4.8.0.520, the command apt-get install -y mono-complete=4.8.0.520-0xamarin3 further below in the file will fail.

The docker install on my machine is broken. Couldn't tests locally.

@vmuriart: I ran this command using Docker for Mac version 17.09.1 (latest from the stable channel) and it built the image and exited without error:

docker build -t pythonnet/pythonnet:python3.6-mono4.8.0-pythonnet2.3.0 -f Dockerfile-python3.6-mono4.8.0-pythonnet2.3.0 .

@jonemo
Copy link
Collaborator

jonemo commented Feb 21, 2018

For anyone else who finds this issue while searching for a Pythonnet Docker image with Python 3.6: To cover the time until the CI workflow in this repo is fixed, I have created a repo with a wider range of Python and Mono versions here, including Python 3.6:

I'd be happy to contribute these back to this repo here if that's of interest to the maintainers, and/or would appreciate feedback and contributions over in https://github.com/jonemo/pythonnet-docker.

@den-run-ai
Copy link
Contributor

@jonemo would you like to try and push this to main pythonnet docker repo? if yes, send me your email address.

@den-run-ai
Copy link
Contributor

@jonemo I added you to both pythonnet-docker and github-pythonnet-docker collaborators. Feel free to push your updates directly there.

@cowboygneox
Copy link

I was added as a collaborator here. Is that a request for me to jump in?

@den-run-ai
Copy link
Contributor

den-run-ai commented Jun 12, 2018 via email

@michaelosthege
Copy link

Hello,
I'm trying to create a Dockerfile that builds FROM continuumio/miniconda3 and uses Python 3.6. I tried to adopt the Dockerfile-python3.6-mono4.8.0-pythonnet2.3.0 from this PR, but the pip installation fails. I think this is the relevant portion of the error log:

Failed building wheel for pythonnet
  Running setup.py clean for pythonnet
Failed to build pythonnet
Installing collected packages: pythonnet
  Running setup.py install for pythonnet: started
    Running setup.py install for pythonnet: finished with status 'error'
    Complete output from command /opt/conda/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-11w71mh7/pythonnet/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-4qjs4_he/install-record.txt --single-version-externally-managed --compile:
    running install
    running build
    running build_ext
    Checking for updates from https://www.nuget.org/api/v2/.
    Currently running NuGet.exe 4.7.1.
    NuGet.exe is up to date.
    MSBuild auto-detection: using msbuild version '14.0' from '/usr/lib/mono/xbuild/14.0/bin'.
    MSBUILD: error MSBUILD0004: Too many project files specified

    WARNING: Error reading msbuild project information, ensure that your input solution or project file is valid. NETCore and UAP projects will be skipped, only packages.config files will be restored.
    All packages listed in packages.config are already installed.

I also tried to run it exactly as it is in this PR, but it fails with the same error.
Could this have something to do with a recent change to the main repo?

@den-run-ai
Copy link
Contributor

@michaelosthege you can probably check in the mono gitter channel first about this weird error "Too many project files specified"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants