Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just use git for checkout #506

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

hauntsaninja
Copy link
Collaborator

actions/checkout is repeatedly flaky. See also actions/checkout#1951

On the other hand, plain git clone seems to work just fine and never has connection issues checking out the default branch or whatever. If we do still see issues, it'll also be much easier to add retries

Funnily enough, the YAML is shorter this way too

actions/checkout is repeatedly flaky

See also actions/checkout#1951

On the other hand, plain git clone seems to work just fine and never has
connection issues checking out the default branch

Funnily enough, the YAML is shorter this way too
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still mystifying to me why it flakes out on this repository so much, and so little on other repositories with similar setups... but if this works, it works!

@hauntsaninja hauntsaninja merged commit bf9a252 into python:main Nov 17, 2024
56 checks passed
@hauntsaninja hauntsaninja deleted the action-checkout branch November 17, 2024 18:49
@hauntsaninja
Copy link
Collaborator Author

I'm not sure what other repos I've seen that use actions/checkout on other repos. mypy_primer just uses git clone. This is the problematic branch https://github.com/actions/checkout/blob/main/src/git-source-provider.ts#L138 (when using actions/checkout on your current repo, ref gets set)

@AlexWaygood
Copy link
Member

I'm not sure what other repos I've seen that use actions/checkout on other repos.

We do it in flake8-pyi: https://github.com/PyCQA/flake8-pyi/blob/a528bc09991768c65fbbb6dd7936560d06df5682/.github/workflows/typeshed_primer.yml#L37

I don't remember ever seeing this issue over there, though admittedly that workflow runs less regularly than this one!

@AlexWaygood
Copy link
Member

We also do it in typeshed, and that workflow runs very regularly: https://github.com/python/typeshed/blob/2419d7520b821752c1181d2105a074ef24b9db81/.github/workflows/tests.yml#L181

@brianschubert
Copy link
Contributor

brianschubert commented Nov 18, 2024

Looks like the workflow is still having timeout issues, even with plain git clones: #508

I wonder if it's hitting some sort of rate limit? If so, maybe staggering tests or running them sequentially may help?

@hauntsaninja
Copy link
Collaborator Author

Hmm. Well, at least it's easy to add retries now: #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants