PEP 513 & 571: Remove libcrypt.so.1 from whitelist #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From pypa/manylinux#305 :
libcrypt.so.1was one of the whitelisted libraries that wheels could assume would always be on the host system. This appears to be no longer the case, as Fedora 30 has moved tolibcrypt.so.2, and some wheels fail to load on that platform.If I have understood correctly,
libcrypto.so.1must therefore be removed from the whitelist. I'd like @njsmith or someone to confirm that I've got the right idea.I'm using Fedora 30, and I've yet to have a wheel fail to load myself, so hopefully this means that not many wheels were linking it anyway, and the practical impact isn't too great.