-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-90370: Avoid temporary varargs
tuple creation in argument passing
#30312
Open
colorfulappl
wants to merge
27
commits into
python:main
Choose a base branch
from
colorfulappl:opt_ac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,134
−212
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b68176d
Avoid temporary `varargs` tuple creation in argument passing
colorfulappl 43b9410
Optimize argument passing of builtin print() with modified Argument C…
colorfulappl 9b37a77
Revert modification of PyAPI_FUNC _PyArg_UnpackKeywordsWithVararg to …
colorfulappl 46e4472
📜🤖 Added by blurb_it.
blurb-it[bot] e06f343
Revert _PyArg_UnpackKeywordsWithVararg and add _PyArg_UnpackKeywordsW…
colorfulappl d35410b
Fix a bug which allows more than one varargs
colorfulappl 0a9fe91
Do not copy posargs and vararg during argument parsing
colorfulappl 9188052
Rename _PyArg_UnpackKeywordsWithVarargFast, it returns kwargs only now
colorfulappl d245ec0
Check type of varargs when generating argument parser
colorfulappl 8d16685
Fix varargssize calculation in class init and add test cases
colorfulappl f4213ea
Merge branch 'main' into opt_ac
colorfulappl 156f8d6
Rerun make clinic
colorfulappl c32aed4
Edit documentation
colorfulappl 7ef5623
Merge branch 'main' into opt_ac
colorfulappl 3ac2821
Fix errors introduced by merging and rerun make clinic
colorfulappl f63a704
Update news
colorfulappl 8f61f5e
Fix varargssize in new_or_init
colorfulappl 1eff215
Simplify the code a bit
colorfulappl 5baf0f5
Optimize generated varargssize assignment
colorfulappl 30c0606
Fix argument passing in new_or_init
colorfulappl d9e7408
Add tests for class method `__new__`
colorfulappl 0f04a95
Merge branch 'main' into opt_ac
colorfulappl 85a8ac5
Correct test function name
colorfulappl a9d1424
Fix vararg parsing when its name is not `args`
colorfulappl d6ff01a
Merge branch 'main' into opt_ac
colorfulappl 597152e
Add testcases for undeclared keyword arguments
colorfulappl 3119fa6
Merge branch 'main' into opt_ac
erlend-aasland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add an exception test with
_b
.