Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-127090: Fix urllib.response.addinfourl.url value for opened file: URIs #127091

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-127090: Fix urllib.response.addinfourl.url value for opened file: URIs #127091

wants to merge 3 commits into from
+6 −7

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Nov 21, 2024 •
edited by bedevere-app bot
Loading

The original file: URL that was passed to urlopen() is now used as the url attribute of the returned addinfourl object. The addinfourl.url attribute always reflects the original file:, data: or ftp: URL now.

@barneygale
pythonGH-127090: Fix urllib.request.addinfourl.url for file: URIs
9c6c313 
The original `file:` URL that was passed to `urlopen()` is now used as the
`url` attribute of the returned `addinfourl` object. The `addinfourl.url`
attribute *always* reflects the original `file:`, `data:` or `ftp:` URL
now.
@bedevere-app bedevere-app bot mentioned this pull request Nov 21, 2024
Open
@barneygale barneygale changed the title GH-127090: Fix urllib.request.addinfourl.url value for opened file: URIs GH-127090: Fix urllib.response.addinfourl.url value for opened file: URIs Nov 21, 2024
@barneygale barneygale marked this pull request as ready for review November 21, 2024 06:29
@barneygale barneygale added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 21, 2024
serhiy-storchaka
serhiy-storchaka reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but there are not enough tests.

I think that you can add checks for url in test_file_notexists and maybe in test_basic and test_copy in urlretrieve_FileTests.

serhiy-storchaka
serhiy-storchaka reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On other hand, the current code removes port and fragment from url, but the changed code will preserve them. I do not know what is more correct.

For history of the current code see 18e4dd7 and 6057ba1 (bpo-8656/gh-52902).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barneygale @serhiy-storchaka