gh-127011: Add __str__ and __repr__ to ConfigParser #127014
Open
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Agent-Hellboy
commented
Nov 19, 2024
•
Agent-Hellboy
commented
- Issue: Add __str__ and __repr__ to ConfigParser for Better Debugging and Unit Testing #127011
| @@ -1040,6 +1042,33 @@ def __iter__(self): | |||
| # XXX does it break when underlying container state changed? | |||
| return itertools.chain((self.default_section,), self._sections.keys()) | |||
|
|
|||
| def __str__(self): | |||
| config_dict = { | |||
| section: dict(self.items(section)) for section in self.sections() | |||
There was a problem hiding this comment.
This performs interpolations on all of the values, which can raise InterpolationError (or other arbitrary exceptions, depending on what interpolation class was specified). I think generally __str__ should be "safe" and not perform operations that can fail unexpectedly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.