-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-87063: Add closed
attribute to multiprocessing.Process
#125838
base: main
Are you sure you want to change the base?
Conversation
It seems that this NEWS error can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More generally, required CI checks must never be ignored except for NEWS missing / issue missing since normal users cannot apply the skip news/issue labels themselves.
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
closed
attribute to multiprocessing.Process
Allow to determine whether a :class:`multiprocessing.Process` has been closed | ||
via the :attr:`~multiprocessing.Process.closed` attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rruuaanng: I encourage you strongly to read the devguide. This change is a new feature, so it needs a What's New entry. Please take a look at existing What's New entries for inspiration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the new changes are satisfactory, but I read what's under Doc/whatnews :). Please review it again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I will repeat again: please read the devguide. If you don't, you will continue to waste review resources.
New features (and especially any new API, like this is) will need a What's New entry. I linked to the section in the devguide that talks about What's New entries, and I also asked you to look at existing entries for inspiration. Apparently, nothing of this was done.
I'll ask you again: please take a look at how we word NEWS and What's New entries for new APIs, and adapt your PR to follow our conventions. Please listen to advice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR author did not listen to feedback. Requesting changes to make this point clearer.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
for example: