-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even more PyDoc_STR #109487
Even more PyDoc_STR #109487
Conversation
Regex used ((PyGetSetDef|PyMemberDef|PyMethodDef|PyStructSequence_Field|PyStructSequence_Desc) .* = \{ [\s\S]* .*?"(?<!\))\}|\{Py_tp_doc, ")
@sobolevn would you mind reviewing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff was rather hard to review, since there are so many changed files.
Plus, this generates quite a lot of blame changes for important pieces of code.
(This is just a statement for others to keep in mind, I still think that this is a proper bug fix).
Co-authored-by: Nikita Sobolev <[email protected]>
Similar to #109393 I also chose to add this to
StructSequence
s because they seem to be doing a similiar thingRegex used
((PyGetSetDef|PyMemberDef|PyMethodDef|PyStructSequence_Field|PyStructSequence_Desc) .* = \{ [\s\S]* .*?"(?<!\))\}|\{Py_tp_doc, ")